mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kapil Arya <ka...@mesosphere.io>
Subject Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.
Date Fri, 18 Aug 2017 17:03:32 GMT


> On Aug. 18, 2017, 12:47 p.m., Till Toenshoff wrote:
> > include/mesos/v1/master/master.proto
> > Line 362 (original), 362 (patched)
> > <https://reviews.apache.org/r/61733/diff/1/?file=1799983#file1799983line362>
> >
> >     Is there any documentation around our deprecation cycles?
> >     I kind of understand that these pubic promises should be handled with very long
deprecation but why a 2.0 and not a 1.2 + N (e.g. 3). We need to be clear and have this publically
documented I believe.
> >     
> >     If there was no JIRA around it, we should create one.

Dropping the issues since the RR just syncs the two files. We should file a separate JIRA
to fix those.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61733/#review183228
-----------------------------------------------------------


On Aug. 18, 2017, 9:32 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61733/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2017, 9:32 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Synchronized comment in v1 and unversioned master.proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/master/master.proto c3fb31de2509adcdec8204f8bbe46b46a31540e8 
> 
> 
> Diff: https://reviews.apache.org/r/61733/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message