mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61600: Rewrited rules for generating Protobuf and gRPC code.
Date Fri, 18 Aug 2017 19:00:37 GMT


> On Aug. 16, 2017, 8:36 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/src/tests/grpc_tests.cpp
> > Line 95 (original), 95 (patched)
> > <https://reviews.apache.org/r/61600/diff/4/?file=1796999#file1796999line95>
> >
> >     Does it make sens to move this unrelated cleanup into a separate patch?
> >     
> >     I also see that in this file generated GRPC-related headers are not sorted correctly,
and invocations like `runtime.call(...)` are always wrapped though not needed.

Addressed in r/61748.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61600/#review183023
-----------------------------------------------------------


On Aug. 18, 2017, 6:58 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61600/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2017, 6:58 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7889
>     https://issues.apache.org/jira/browse/MESOS-7889
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made code generation for Proobuf and gRPC more generic and changed the
> variable names in `Makefile.am` to follow the same style in Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c2fa3f9e81cb57bc9cb43f8f057014668bc49246 
> 
> 
> Diff: https://reviews.apache.org/r/61600/diff/5/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message