mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61600: Rewrited rules for generating Protobuf and gRPC code.
Date Sat, 19 Aug 2017 00:34:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61600/
-----------------------------------------------------------

(Updated Aug. 19, 2017, 12:34 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
-------

Added a dependency between `tests` and `$(GRPC_TESTS_PROTOS)` since the generated code need
to be created after `grpc` is built (enforced through `BUILT_SOURCES`) but before `grpc_tests.cpp`
is compiled.


Summary (updated)
-----------------

Rewrited rules for generating Protobuf and gRPC code.


Bugs: MESOS-7889
    https://issues.apache.org/jira/browse/MESOS-7889


Repository: mesos


Description
-------

Made code generation for Proobuf and gRPC more generic and changed the
variable names in `Makefile.am` to follow the same style in Mesos.


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am c2fa3f9e81cb57bc9cb43f8f057014668bc49246 


Diff: https://reviews.apache.org/r/61600/diff/6/

Changes: https://reviews.apache.org/r/61600/diff/5-6/


Testing
-------

make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message