mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 61705: Added a mock CSI plugin and a unit test for CSI client classes.
Date Sat, 19 Aug 2017 00:37:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61705/
-----------------------------------------------------------

(Updated Aug. 19, 2017, 12:37 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed @jieyu's comments.


Bugs: mesos-7491
    https://issues.apache.org/jira/browse/mesos-7491


Repository: mesos


Description (updated)
-------

The mock plugin simply starts the `Identity`, `Controller` and `Node`
CSI services and return a success with an empty response protocol buffer
for each RPC. The unit test verifies that each method in the `Client`
class makes the corresponding RPC call through the gRPC interface in
libprocess.


Diffs (updated)
-----

  src/tests/csi_client_tests.cpp PRE-CREATION 
  src/tests/mock_csi_plugin.hpp PRE-CREATION 
  src/tests/mock_csi_plugin.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/61705/diff/2/

Changes: https://reviews.apache.org/r/61705/diff/1-2/


Testing
-------

Tests described in r/61706.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message