mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Re: Review Request 61189: Added authorization for V1 events.
Date Sat, 19 Aug 2017 03:33:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61189/
-----------------------------------------------------------

(Updated Aug. 19, 2017, 3:33 a.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, and Greg Mann.


Bugs: MESOS-7785
    https://issues.apache.org/jira/browse/MESOS-7785


Repository: mesos


Description
-------

Added authorization filtering for the V1 operator events on the
master, the subscriber should only receive events that are
authorized based on their principal and ACLs. Since the authorizer
is called for every event emitted on the stream, the change of
authorization rule will affect events that the subscribers can
receive.


Diffs (updated)
-----

  src/master/http.cpp b09a9d0ab5fab179d0e400932dce7d3ca958d7a8 
  src/master/master.hpp d9cfc42646c874661e4ec79322126d93a2caf604 
  src/master/master.cpp 7f38a5e21884546d4b4c866ca5918db779af8f99 
  src/tests/api_tests.cpp 34480ea6818c904c64cb678562866f0b43dae0d6 


Diff: https://reviews.apache.org/r/61189/diff/5/

Changes: https://reviews.apache.org/r/61189/diff/4-5/


Testing
-------

make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="ContentType/MasterAPITest.EventsAuthorizationFiltering*"
--verbose --gtest_repeat=100 --gtest_break_on_failure


Thanks,

Quinn Leng


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message