mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61766: Made the output handling of TCP and HTTP checks consistent.
Date Mon, 21 Aug 2017 13:41:05 GMT


> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote:
> > src/checks/checker_process.cpp
> > Lines 913-920 (original), 913-920 (patched)
> > <https://reviews.apache.org/r/61766/diff/1/?file=1800336#file1800336line913>
> >
> >     Let's print stderr regardless of the retcode, what you now do with the command
checks. It is probably not much value to do so here, but it is _consistent_ : ).

Thinking more about it, I lean towards your solution and not print anything unless there was
a curl failure. HTTP checks are actually not meant to be processes, so printing `curl`'s stdout
and stderr is not necessary.


> On Aug. 21, 2017, 1:34 p.m., Alexander Rukletsov wrote:
> > src/checks/checker_process.cpp
> > Lines 1071-1076 (original), 1075-1080 (patched)
> > <https://reviews.apache.org/r/61766/diff/1/?file=1800336#file1800336line1075>
> >
> >     Let's print it regardless of the retcode, what you now do with the command checks.
It is probably not much value to do so for the tcp checker, but it is _consistent_ : ).

Thinking more about it, I lean towards your solution and not print anything unless there was
a `tcp-connect` failure. TCP checks are actually not meant to be processes, so printing `tcp-connect`'s
stdout and stderr is not necessary.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61766/#review183332
-----------------------------------------------------------


On Aug. 19, 2017, 12:27 a.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61766/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2017, 12:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7861
>     https://issues.apache.org/jira/browse/MESOS-7861
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made the output handling of TCP and HTTP checks consistent.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e 
> 
> 
> Diff: https://reviews.apache.org/r/61766/diff/1/
> 
> 
> Testing
> -------
> 
> `make tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message