mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 61697: Included nested command checks output in the executor logs.
Date Mon, 21 Aug 2017 18:10:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61697/#review183351
-----------------------------------------------------------




src/checks/checker_process.cpp
Lines 143-146 (patched)
<https://reviews.apache.org/r/61697/#comment259385>

    Could you add a note here with a link to MESOS-7903, saying that we would like to refactor
this into a common helper?



src/checks/checker_process.cpp
Lines 149-150 (patched)
<https://reviews.apache.org/r/61697/#comment259383>

    This seems more concise to me, and just as readable:
    
    s/stdoutReceived/stdout/
    s/stderrReceived/stderr/
    
    what do you think?



src/checks/checker_process.cpp
Lines 161 (patched)
<https://reviews.apache.org/r/61697/#comment259387>

    Does `return Error(records.error());` not work here? And below.



src/checks/checker_process.cpp
Lines 588 (patched)
<https://reviews.apache.org/r/61697/#comment259388>

    s/timed out/timed-out/


- Greg Mann


On Aug. 18, 2017, 11:20 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61697/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2017, 11:20 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-7861
>     https://issues.apache.org/jira/browse/MESOS-7861
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the default executor include the output of the COMMAND
> (health) checks in its logs.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.cpp 30dda0e6efca31aa6b9cd4f753f96b979717ab2e 
> 
> 
> Diff: https://reviews.apache.org/r/61697/diff/3/
> 
> 
> Testing
> -------
> 
> Manual tests.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message