mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Review Request 61798: Added _EXIT as alternative to ABORT.
Date Mon, 21 Aug 2017 20:54:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61798/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin Mahler, and James
Peach.


Bugs: MESOS-7791
    https://issues.apache.org/jira/browse/MESOS-7791


Repository: mesos


Description
-------

EXIT macro can't be used when async-signal safety is required.

Currently, ABORT is used for terminating a program after both
unexpected and expected errors, when async-signal safety is required.
In case of expected errors, `abort` causes coredumps, which might be
undesirable.

In addition, _EXIT takes variable number of arguments, thereby _EXIT
interface doesn't force users to concatenate strings, thus making its
usage more async-signal safe.


Diffs
-----

  3rdparty/stout/include/stout/exit.hpp e5c2d3440a85ab2d2cae551ee4094cd965e38dfc 


Diff: https://reviews.apache.org/r/61798/diff/1/


Testing
-------

sudo make check (mac os x, fedora 25)
internal CI


Thanks,

Andrei Budnik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message