mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59746: Stopped accounting aborted container launches as failures.
Date Tue, 22 Aug 2017 13:47:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59746/
-----------------------------------------------------------

(Updated Aug. 22, 2017, 1:47 p.m.)


Review request for mesos, Ian Downes, Jie Yu, Joseph Wu, and Jan Schlicht.


Changes
-------

Employed a different approach: ignore both failures and discards if executor has been asked
to shutdown.


Summary (updated)
-----------------

Stopped accounting aborted container launches as failures.


Bugs: MESOS-7601
    https://issues.apache.org/jira/browse/MESOS-7601


Repository: mesos


Description (updated)
-------

The container launch future might be failed or discarded (depending
on the containerizer implementation) if the launch has been aborted,
for example, a framework might have stopped while its task are being
started. Such failures should not be accounted as launch errors.


Diffs (updated)
-----

  src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a 


Diff: https://reviews.apache.org/r/59746/diff/2/

Changes: https://reviews.apache.org/r/59746/diff/1-2/


Testing (updated)
-------

`make check` on several Linux distros.

Additional manual tests for (1) mesos and (1) docker containerizers. The framework is asked
to exit right after it submits the task to mesos.

(1) With mesos c-zer
m: `./bin/mesos-master.sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=mesos
--image_providers="DOCKER" --isolation=filesystem/linux,docker/runtime`
f: `./src/mesos-execute --master=<ip>:5050 --containerizer=mesos --docker_image=fedora:25
--name=pull-test --command="sleep 1000"`

(2) With docker c-zer
m: `./bin/mesos-master.sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=<ip>:5050 --work_dir=./a --containerizers=docker`
f: `./src/mesos-execute --master=<ip>:5050 --containerizer=docker --docker_image=fedora:25
--name=pull-test --command="sleep 1000"`


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message