mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 61873: Added test filter for docker user network tests.
Date Thu, 24 Aug 2017 09:43:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61873/#review183722
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/environment.cpp
Line 296 (original), 315-316 (patched)
<https://reviews.apache.org/r/61873/#comment259772>

    Better to put `Option<Error> dockerUserNetworkError;` under `Option<Error>
dockerError;`.


- Qian Zhang


On Aug. 24, 2017, 8:59 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61873/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 8:59 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-7807
>     https://issues.apache.org/jira/browse/MESOS-7807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test filter for docker user network tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5 
> 
> 
> Diff: https://reviews.apache.org/r/61873/diff/1/
> 
> 
> Testing
> -------
> 
> make, make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message