mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 61874: Added a test for IPv6 containers on docker user networks.
Date Fri, 25 Aug 2017 01:26:18 GMT


> On Aug. 24, 2017, 10:21 a.m., Qian Zhang wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4753 (patched)
> > <https://reviews.apache.org/r/61874/diff/1/?file=1802826#file1802826line4753>
> >
> >     I think we should call this method in the end rather than at the beginning.

We need the containers to be removed from the network before the network can be deleted. So
need call tear down on the base class before deleting the network.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61874/#review183724
-----------------------------------------------------------


On Aug. 24, 2017, 12:59 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61874/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 12:59 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-7807
>     https://issues.apache.org/jira/browse/MESOS-7807
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test creates a IPv6 docker user network. It than launches an alpine
> image on the docker user network. Finally it checks if the IP address
> allocated to the container are reflected correctly in state.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 6856ca22570183b022d401d1fa8f59d819783eed

> 
> 
> Diff: https://reviews.apache.org/r/61874/diff/1/
> 
> 
> Testing
> -------
> 
> sudo bin/mesos-tests.sh --gtest_filter="*.ROOT_DOCKER_USERNETWORK_LaunchIPv6Container"
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from DockerContainerizerIPv6UserNetworkTest
> [ RUN      ] DockerContainerizerIPv6UserNetworkTest.ROOT_DOCKER_USERNETWORK_LaunchIPv6Container
> [       OK ] DockerContainerizerIPv6UserNetworkTest.ROOT_DOCKER_USERNETWORK_LaunchIPv6Container
(15660 ms)
> [----------] 1 test from DockerContainerizerIPv6UserNetworkTest (15664 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (15713 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message