mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 61662: Added SlaveRecoveryTest.RebootWithSlaveInfoMismatchAndRestart test.
Date Mon, 28 Aug 2017 19:55:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61662/#review183976
-----------------------------------------------------------


Ship it!




Will fix the nit when committing.


src/tests/slave_recovery_tests.cpp
Lines 2852-2853 (patched)
<https://reviews.apache.org/r/61662/#comment260013>

    Nit: "before" sounds like we are merely racing against it when we are completely preventing
it.
    
    Here I think it sufficies to say:
    
    ```
    // Simulate an agent restart before reregistration completes.
    ```


- Jiang Yan Xu


On Aug. 15, 2017, 7:48 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61662/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 7:48 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7795
>     https://issues.apache.org/jira/browse/MESOS-7795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new test verifies that the agent removes the 'latest' symlink when it decides to
recover as a new one after reboot. And that it can successfully recover again if restarted
before checkpointing new agent info.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 9ba6f6005c2edce67e1f63005518ab71ac981423 
> 
> 
> Diff: https://reviews.apache.org/r/61662/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `make check`. Verified that this test fails without the bugfix patch.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message