mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61915: Enabled `DockerContainerizerProcess::usage` for all platforms.
Date Mon, 28 Aug 2017 20:14:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61915/#review183979
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/docker.cpp
Lines 1869-1870 (patched)
<https://reviews.apache.org/r/61915/#comment260016>

    Let's insert a blank line here.


- Alexander Rukletsov


On Aug. 25, 2017, 8:32 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61915/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2017, 8:32 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joseph Wu, Kevin Klues, and Li Li.
> 
> 
> Bugs: MESOS-7917
>     https://issues.apache.org/jira/browse/MESOS-7917
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When originally implemented this code was enabled only for Linux.
> However, this code should work anywhere Docker is being used, as it
> obtains the information by shelling out to the `docker` executable.
> 
> This patch fixes the resources information provided by the `mesos-agent`
> on Windows platforms for Docker containers by making the `statistics`
> JSON object available.
> 
> Note that the `cgroupsStatistics` is Linux specific, and so the
> pre-processor guard was not removed but reduced in scope for just it.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp cbcff39a5d8398f71570849615aeb4368130b433 
> 
> 
> Diff: https://reviews.apache.org/r/61915/diff/1/
> 
> 
> Testing
> -------
> 
> Built on Windows, started a Windows Docker container, observed the `statistics` field
from `<theagent>/container` being populated where it was not previously included.
> 
> `make check` passed on CentOS 7.
> 
> Diagnosing the Windows tests, have a machine configuration with Docker containers right
now.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message