mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61905: Integrated 'volume/host_path' into MesosContainerizer.
Date Mon, 28 Aug 2017 21:42:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61905/#review183982
-----------------------------------------------------------


Ship it!





src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Line 518 (original), 514 (patched)
<https://reviews.apache.org/r/61905/#comment260018>

    Since this line is being changed, might as well use `path::absolute` too.


- Joseph Wu


On Aug. 24, 2017, 5 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61905/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 5 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removed the host volume logics from the 'filesystem/linux'
> isolator, and integrated the new 'volume/host_path' isolator. For
> backward compatibility, we always enable 'volume/host_path' isolator
> if 'filesystem/linux' isolator is enabled.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp f91eef22dbaf040cb0026862cd8922d84c090b73

>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp d7fe9a8f43ab6436fc1e202443e71cf6b7e2d0d3

> 
> 
> Diff: https://reviews.apache.org/r/61905/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message