mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 60622: Add new stout function: path::uri (convert filename to valid URI).
Date Mon, 28 Aug 2017 22:29:45 GMT


> On Aug. 15, 2017, 6:04 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/stout/include/stout/path.hpp
> > Lines 77 (patched)
> > <https://reviews.apache.org/r/60622/diff/1/?file=1768697#file1768697line77>
> >
> >     If this is the case, what are we doing on Linux if the path has backslashes
in it?
> >     
> >     I recognize this wasn't already previously handled, but it's a good question.
Should this function be normalizing as well?

On Linux, backslashes are a valid part of the filename. We can't just "normalize" this was
that makes the filename fundamentally different. You can percent-encode a URI to contain a
'\' character, but then this would imply that we have a URI decode function, and today we
don't have that in any common form.

This was always a problem on Linux - my changes don't affect that one way or the other. If
this is a problem for customers, we should create a separate bug for this and fix it separately
from these changes.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60622/#review182967
-----------------------------------------------------------


On July 3, 2017, 7:30 p.m., Jeff Coffler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60622/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 7:30 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li.
> 
> 
> Bugs: MESOS-6705
>     https://issues.apache.org/jira/browse/MESOS-6705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add new stout function: path::uri (convert filename to valid URI).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/path.hpp 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 
>   3rdparty/stout/tests/path_tests.cpp f8c14d5aefe0b49adb778da784143a328c96183d 
> 
> 
> Diff: https://reviews.apache.org/r/60622/diff/1/
> 
> 
> Testing
> -------
> 
> See upstream
> 
> 
> Thanks,
> 
> Jeff Coffler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message