mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 61929: Parameterized the volume host path tests on executor type.
Date Mon, 28 Aug 2017 23:09:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61929/#review184004
-----------------------------------------------------------


Ship it!




None of our other test parameterization goes this far, but this certainly looks more neat
than parameterizing on a `bool` or `string`.

- Joseph Wu


On Aug. 26, 2017, 1:21 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61929/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2017, 1:21 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows us to test the isolator when the container is a normal
> container (command executor) or a nested container (default executor).
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp PRE-CREATION 
>   src/tests/mesos.hpp f80e5fb0b76146e4748192361e8d1feff1ed687e 
> 
> 
> Diff: https://reviews.apache.org/r/61929/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message