mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 61690: Added `--zk_session_timeout` flag for agent.
Date Wed, 30 Aug 2017 06:05:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61690/#review184126
-----------------------------------------------------------


Ship it!





src/slave/flags.cpp
Lines 1263 (patched)
<https://reviews.apache.org/r/61690/#comment260192>

    I can add a TODO here...
    
    // TODO: Share the default ZK session timeout across master and agent.


- Jiang Yan Xu


On Aug. 25, 2017, 10:05 a.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61690/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2017, 10:05 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7895
>     https://issues.apache.org/jira/browse/MESOS-7895
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently `ZooKeeperMasterDetector` in agent uses default session
> timeout and there's no way to configure it. This patch introduces
> `--zk_session_timeout` flag for agent similar to the one in master.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60 
>   src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f 
>   src/slave/main.cpp a4a8ced6825ece1b25003824d987ff83fb799ad7 
> 
> 
> Diff: https://reviews.apache.org/r/61690/diff/1/
> 
> 
> Testing
> -------
> 
> Ran `make check`.
> 
> Manually verified that ZK session negotiates 20 secs timeout instead of 10 secs when
the agent is started with `--zk_session_timeout=20secs`.
> ```
> 2017-08-15 17:50:32,065:7763(0x70000051c000):ZOO_INFO@check_events@1728: initiated connection
to server [192.168.99.100:2181]
> 2017-08-15 17:50:32,069:7763(0x70000051c000):ZOO_INFO@check_events@1775: session establishment
complete on server [192.168.99.100:2181], sessionId=0x15de6c7f8920001, negotiated timeout=20000
> ```
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message