mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 61981: Added unit test for killing the default executor process.
Date Wed, 30 Aug 2017 09:19:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184136
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/default_executor_tests.cpp
Lines 1384 (patched)
<https://reviews.apache.org/r/61981/#comment260197>

    Can you please add some comments to explain the purpose of this test?



src/tests/default_executor_tests.cpp
Lines 1455 (patched)
<https://reviews.apache.org/r/61981/#comment260198>

    We do not need this comment.



src/tests/default_executor_tests.cpp
Lines 1465 (patched)
<https://reviews.apache.org/r/61981/#comment260199>

    Ditto.


- Qian Zhang


On Aug. 30, 2017, 4:29 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2017, 4:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-7926
>     https://issues.apache.org/jira/browse/MESOS-7926
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit test for killing the default executor process.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1 
> 
> 
> Diff: https://reviews.apache.org/r/61981/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message