mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 61579: Ensured JAVA HTTP adapter propagates a subscription error.
Date Wed, 30 Aug 2017 14:16:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61579/
-----------------------------------------------------------

(Updated Aug. 30, 2017, 2:16 p.m.)


Review request for mesos, Anand Mazumdar, Till Toenshoff, and Vinod Kone.


Bugs: MESOS-7872
    https://issues.apache.org/jira/browse/MESOS-7872


Repository: mesos


Description
-------

Prior to this patch, if an error occurred during subscription /
registration to the master, it was not propagated back to the
scheduler if the HTTP adapter was used. This happened because
the HTTP adapter does not call `scheduler.connected` until after
successful registration and hence the scheduler does not try to
send the `SUBSCRIBE` call, without which the adapter does not
send any events to the scheduler.

A fix is to call `scheduler.connected` if an error occurred
before the scheduler had subscribed.


Diffs (updated)
-----

  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 1f58fbff4e8414e4d2ae4c8f69b637ee3315e411



Diff: https://reviews.apache.org/r/61579/diff/2/

Changes: https://reviews.apache.org/r/61579/diff/1-2/


Testing
-------

See https://reviews.apache.org/r/61580/


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message