mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 60591: Optionally isolate only the agent network ports.
Date Wed, 30 Aug 2017 23:20:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60591/
-----------------------------------------------------------

(Updated Aug. 30, 2017, 11:20 p.m.)


Review request for mesos, Qian Zhang and Jiang Yan Xu.


Bugs: MESOS-7675
    https://issues.apache.org/jira/browse/MESOS-7675


Repository: mesos


Description
-------

Normally, the `network/ports` isolator will kill any task that
listens on a port that it does not have resources for. However,
executors that are based on the libprocess API will always
listen on a port in the ephemeral range, and we want to make
it possible to use libprocess-based executors.

Added the `--check_agent_port_range_only` option to only kill
tasks when they listen on un-allocated ports within the port
range published by the agent resources. This still prevents
port collisions between tasks, but doesn't kill them just
because the executor is listening on a port.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION 
  src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60 
  src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f 


Diff: https://reviews.apache.org/r/60591/diff/17/

Changes: https://reviews.apache.org/r/60591/diff/16-17/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message