mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 62003: Added `network/ports` isolator nested container tests.
Date Wed, 30 Aug 2017 23:25:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62003/#review184217
-----------------------------------------------------------



Bad patch!

Reviews applied: [62003, 60593, 60765, 60903, 60766, 60591, 60592, 60496, 61536, 60495, 60492,
60902, 61538, 60836, 60901, 60764, 60494, 60493, 60491]

Failed command: python support/apply-reviews.py -n -r 60766

Error:
2017-08-30 23:25:42 URL:https://reviews.apache.org/r/60766/diff/raw/ [7058/7058] -> "60766.patch"
[1]
error: patch failed: src/slave/containerizer/mesos/isolators/network/ports.hpp:85
error: src/slave/containerizer/mesos/isolators/network/ports.hpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/isolators/network/ports.cpp:354
error: src/slave/containerizer/mesos/isolators/network/ports.cpp: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19133/console

- Mesos Reviewbot


On Aug. 30, 2017, 11:16 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62003/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos, Qian Zhang and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7675
>     https://issues.apache.org/jira/browse/MESOS-7675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `network/ports` isolator nested container tests using the v1
> TaskGroups API. This tests that rogue port usage by a nested task is
> detected both with and without agent recovery, and that a well-behaved
> task is preserved across agent recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62003/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message