mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Deepak Goel <deepak.go...@gmail.com>
Subject Review Request 62017: Allows port mapper plugin to have optional args.
Date Thu, 31 Aug 2017 16:16:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62017/
-----------------------------------------------------------

Review request for mesos and Avinash sridharan.


Bugs: mesos-7923
    https://issues.apache.org/jira/browse/mesos-7923


Repository: mesos


Description
-------

Mesos port mapper cni plugin is a wrapper around bridge plugin
to add port mapping functionality to bridge plugin. However, in
certain cases the network creator doesn't need port mapping
functionality and just want to access bridge plugin. In this case,
the creator may not supply `args` in cni config which will makes
mesos port mapper plugin to fail. This patch makes `args` in cni
config optional for mesos port mapper plugin


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
43cf3e44a55c56dc8195c9cd05f6edd8bf13d448 


Diff: https://reviews.apache.org/r/62017/diff/1/


Testing
-------


Thanks,

Deepak Goel


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message