mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 62005: Used 'undiscardable' to protect a future in MesosContainerizer.
Date Thu, 31 Aug 2017 23:31:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62005/#review184326
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Aug. 31, 2017, 4:27 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62005/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Gilbert Song.
> 
> 
> Bugs: MESOS-7926
>     https://issues.apache.org/jira/browse/MESOS-7926
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch addressed MESOS-7926 by protecting 'termination.future()'
> with 'undiscardable'. This prevented the upstream discard event from
> being propagated into 'termination.future()' which gets reused for
> other calls.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 5f9373a88819ae1e0ceae708dccbed5383684918

> 
> 
> Diff: https://reviews.apache.org/r/62005/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Ran the test in https://reviews.apache.org/r/61981 which previously fails. With this
patch, the test passes.
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message