mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <>
Subject Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.
Date Thu, 07 Sep 2017 05:54:51 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 7, 2017, 5:54 a.m.)

Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Vinod Kone.


Edited testing done

Repository: mesos


Instead of relying on `Clock::pause()/settle()` to ensure that no
callbacks on the scheduler were in flight, the test
helper can wait on the future returned by `stop()` now. This is
possible as we acquire the mutex explicitly in `stop()` to ensure
that there can't be any queued callbacks that get executed after
`TestMesos` is destroyed.


  include/mesos/v1/scheduler.hpp d56e08861d5190ef66992d383dc5710d8f6ce661 
  src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744 
  src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 


Testing (updated)

make check (Ensured tests still work when run in a loop)


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message