mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 61982: Cleaned up DefaultExecutor tests.
Date Sat, 09 Sep 2017 00:03:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61982/
-----------------------------------------------------------

(Updated Sept. 9, 2017, 12:03 a.m.)


Review request for mesos, Anand Mazumdar and Greg Mann.


Changes
-------

Used the new `createExecutorInfo` overloads.


Bugs: MESOS-7916
    https://issues.apache.org/jira/browse/MESOS-7916


Repository: mesos


Description
-------

Update the DefaultExecutor tests to use test helpers where possible.
Also make the boilerplate initialization code consistent across tests.


Diffs (updated)
-----

  src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 


Diff: https://reviews.apache.org/r/61982/diff/4/

Changes: https://reviews.apache.org/r/61982/diff/3-4/


Testing
-------

`sudo bin/mesos-tests.sh --gtest_filter="*DefaultExecutor*"` succeeds on GNU/Linux


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message