mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups.
Date Tue, 12 Sep 2017 22:39:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62253/#review185239
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 12, 2017, 6:28 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62253/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 6:28 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7969
>     https://issues.apache.org/jira/browse/MESOS-7969
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cgroups v2 hierarchies don't list the "controllers" field (e.g., "0::/user.slice/user-1000.slice/session-5.scope)
is empty and hence the cgroup parser failes. We should simply skip over fields with empty
controller field.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 95c81d90f956e11d23e965dd0d0b83a66220d858 
> 
> 
> Diff: https://reviews.apache.org/r/62253/diff/1/
> 
> 
> Testing
> -------
> 
> make check on Fedora 26.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message