mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 62472: Fixed the ordering of Mesos containerizer isolators.
Date Thu, 21 Sep 2017 17:47:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62472/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Kevin Klues.


Bugs: MESOS-7643
    https://issues.apache.org/jira/browse/MESOS-7643


Repository: mesos


Description
-------

Historically, isolators were invoked in the order listed by
the operator in the `--isolation` flag. This changed to an
internal ordering in 6fb9c024, back to the operator ordering
in af474a6fa, and then to an undefined ordering in 9642d3c67b.

This commit switches back to an internal ordering for all the built-in
isolators. Custom isolators loaded in modules are run in operator order
after all the built-in ones. The rationale for an internal ordering is
expressed in MESOS-5581; basically we should not burden the operator
with having to figure out how to make the order correct. In the case of
custom isolators there's no way for us to know the correct ordering so
we make an arbitrary choice.


Diffs
-----

  src/slave/containerizer/mesos/containerizer.cpp 4d5dc13f363f5d8886983d7dd06a5cecc177c345



Diff: https://reviews.apache.org/r/62472/diff/1/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message