mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 62434: Fixed horizontal ellipsis in Web UI.
Date Thu, 21 Sep 2017 19:42:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185915
-----------------------------------------------------------


Fix it, then Ship it!




I can't tell from the testing section, but I'll assume that you tested this by starting an
agent and looking at it's ID. If not, can you please do so and follow up if there's an issue?


src/webui/master/static/js/app.js
Line 92 (original), 92 (patched)
<https://reviews.apache.org/r/62434/#comment262253>

    It's a little less clear what this is doing now, how about a comment?
    
    An example for agent id is:
    9d4b2f2b-a759-4458-bebf-7d3507a6f0ca-S9
    ...bebf-7d3507a6f0ca-S9
    
    // Returns a truncated ID, for example:
    // Input: 9d4b2f2b-a759-4458-bebf-7d3507a6f0ca-S9
    // Output: ...bebf-7d3507a6f0ca-S9
    //
    // Note that an ellipsis is used for display purposes.


- Benjamin Mahler


On Sept. 20, 2017, 10:32 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 10:32 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7978
>     https://issues.apache.org/jira/browse/MESOS-7978
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We were previously using non-printable characters which 
> is an issue for the JavaScript linter we plan to use.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce 
> 
> 
> Diff: https://reviews.apache.org/r/62434/diff/1/
> 
> 
> Testing
> -------
> 
> Change in the UI tested with Google Chrome 61.0.3163.91.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message