mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 62477: Added the gone agents to the master registry.
Date Mon, 25 Sep 2017 23:56:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62477/#review186176
-----------------------------------------------------------




src/master/master.hpp
Lines 2306 (patched)
<https://reviews.apache.org/r/62477/#comment262625>

    Looks like this is not possible according to the code in the next review. If so, can you
return an `Error` with a comment similar to #2127.


- Vinod Kone


On Sept. 21, 2017, 8:27 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62477/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 8:27 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7444
>     https://issues.apache.org/jira/browse/MESOS-7444
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the list of gone agents to the registry and also
> introduces the `MarkSlaveGone` operation on the Mesos master. This
> would be used by the Master Operator API handler to insert an agent
> into the list of gone agent.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 
>   src/master/registry.proto 362a9fab946e9fb0411df2277f7f3edbadccb61a 
>   src/tests/registrar_tests.cpp b5fc45887e25345d49feb4975f6256cfd7b0fe55 
> 
> 
> Diff: https://reviews.apache.org/r/62477/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message