| Gilbert Song |
Re: Review Request 61981: Added unit test for killing the default executor process. |
Fri, 01 Sep, 06:23 |
| Gilbert Song |
Re: Review Request 61981: Added unit test for killing the default executor process. |
Fri, 01 Sep, 06:23 |
| Anand Mazumdar |
Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter. |
Fri, 01 Sep, 06:27 |
| Alexander Rukletsov |
Re: Review Request 61991: Added several logs to the C++ part of the v1-v0 adapter. |
Fri, 01 Sep, 08:36 |
| Till Toenshoff |
Re: Review Request 61849: Improved consistency of cout/cerr and glog usage in main functions. |
Fri, 01 Sep, 09:16 |
| Jan Schlicht |
Re: Review Request 61810: Added a function to apply offer operations. |
Fri, 01 Sep, 10:23 |
| Jan Schlicht |
Re: Review Request 61946: Added validation of resource provider operations. |
Fri, 01 Sep, 10:23 |
| Jan Schlicht |
Re: Review Request 61947: Implemented handling of resource provider offer operations. |
Fri, 01 Sep, 10:23 |
| Armand Grillet |
Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 01 Sep, 15:47 |
| Mesos Reviewbot |
Re: Review Request 62037: Added logging::initialize to main functions that use glog. |
Fri, 01 Sep, 17:55 |
| Jiang Yan Xu |
Re: Review Request 60960: Added an enum to track Metric semantics. |
Fri, 01 Sep, 18:02 |
| James Peach |
Re: Review Request 60960: Added an enum to track Metric semantics. |
Fri, 01 Sep, 18:07 |
| Jiang Yan Xu |
Re: Review Request 61126: Converted Timer value to counting semantics. |
Fri, 01 Sep, 18:24 |
| James Peach |
Re: Review Request 61126: Converted Timer value to counting semantics. |
Fri, 01 Sep, 18:26 |
| Jiang Yan Xu |
Re: Review Request 61125: Track the total number of time series samples. |
Fri, 01 Sep, 18:30 |
| Mesos Reviewbot |
Re: Review Request 61982: Cleaned up DefaultExecutor tests. |
Fri, 01 Sep, 20:48 |
| Gastón Kleiman |
Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 01 Sep, 21:28 |
| Joerg Schad |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 01 Sep, 22:22 |
| James Peach |
Re: Review Request 61125: Track the total number of time series samples. |
Fri, 01 Sep, 22:39 |
| Mesos Reviewbot |
Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards. |
Fri, 01 Sep, 22:39 |
| Zhitao Li |
Review Request 62040: Also log attached path in agent. |
Fri, 01 Sep, 22:53 |
| Zhitao Li |
Review Request 62047: Allowed look up latest executor directory by virtual path. |
Fri, 01 Sep, 22:54 |
| Benjamin Mahler |
Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 00:38 |
| Benjamin Mahler |
Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 00:38 |
| Benjamin Mahler |
Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 00:38 |
| Mesos Reviewbot |
Re: Review Request 62047: Allowed look up latest executor directory by virtual path. |
Sat, 02 Sep, 00:38 |
| Qian Zhang |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Sat, 02 Sep, 02:08 |
| Mesos Reviewbot |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 02:28 |
| Chun-Hung Hsiao |
Re: Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 02:29 |
| Chun-Hung Hsiao |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 02:35 |
| Chun-Hung Hsiao |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 02:37 |
| Jie Yu |
Re: Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 02:56 |
| Jie Yu |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 03:01 |
| Jie Yu |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 03:09 |
| Benjamin Mahler |
Re: Review Request 62049: Fixed an OOM due to a send loop for SSL sockets. |
Sat, 02 Sep, 03:10 |
| Benjamin Mahler |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 03:15 |
| Benjamin Mahler |
Re: Review Request 62050: Added a test to reproduce the OOM issue in MESOS-7934. |
Sat, 02 Sep, 03:15 |
| Benjamin Mahler |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 03:15 |
| Benjamin Mahler |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 03:16 |
| Mesos Reviewbot |
Re: Review Request 62051: Clarified some issues in the LibeventSSLSocket event_callback logic. |
Sat, 02 Sep, 04:20 |
| Joseph Wu |
Re: Review Request 61323: Added `picojson` interface library. |
Sat, 02 Sep, 14:21 |
| Joseph Wu |
Re: Review Request 61308: Updated the ZooKeeper patch. |
Sat, 02 Sep, 14:26 |
| Joseph Wu |
Re: Review Request 61327: Imported `zlib` library. |
Sat, 02 Sep, 14:32 |
| Joseph Wu |
Re: Review Request 61330: Added `nvml` interface library. |
Sat, 02 Sep, 14:35 |
| Joseph Wu |
Re: Review Request 61334: Imported `http_parser` library. |
Sat, 02 Sep, 14:41 |
| Joseph Wu |
Re: Review Request 61336: Prioritized provided paths in `FindPackageHelper`. |
Sat, 02 Sep, 14:54 |
| Joseph Wu |
Re: Review Request 61337: Imported `apr` library. |
Sat, 02 Sep, 15:01 |
| Benjamin Hindman |
Review Request 62053: Removed garbage collector. |
Sat, 02 Sep, 15:07 |
| Joseph Wu |
Re: Review Request 61340: Imported `leveldb` library. |
Sat, 02 Sep, 15:09 |
| Joseph Wu |
Re: Review Request 61343: Supported finding the correct subversion libraries on macOS. |
Sat, 02 Sep, 15:15 |
| Joseph Wu |
Re: Review Request 61344: Imported `svn` library. |
Sat, 02 Sep, 15:47 |
| Joseph Wu |
Re: Review Request 61346: Imported `gtest` and `gmock` libraries with a `googletest` interface. |
Sat, 02 Sep, 15:56 |
| Joseph Wu |
Re: Review Request 61350: Removed `GroupSource` usage from `libprocess`. |
Sat, 02 Sep, 16:11 |
| Jie Yu |
Re: Review Request 58048: Added id to Resource.DiskInfo. |
Sat, 02 Sep, 16:27 |
| Joseph Wu |
Re: Review Request 61351: Removed `GroupSource.cmake`. |
Sat, 02 Sep, 16:35 |
| Joseph Wu |
Re: Review Request 61357: Imported `libev` and `libevent` libraries. |
Sat, 02 Sep, 16:58 |
| Joseph Wu |
Re: Review Request 61291: Imported `glog` library. |
Sat, 02 Sep, 17:42 |
| Joseph Wu |
Re: Review Request 61314: Added `boost` interface library. |
Sat, 02 Sep, 17:44 |
| Andrew Schwartzmeyer |
Re: Review Request 61295: Linked `stout` interface library to `protobuf` imported library. |
Sat, 02 Sep, 17:52 |
| Joseph Wu |
Re: Review Request 61292: Linked `stout` interface library to `glog` imported library. |
Sat, 02 Sep, 18:07 |
| Mesos Reviewbot |
Re: Review Request 61351: Removed `GroupSource.cmake`. |
Sat, 02 Sep, 18:54 |
| Joseph Wu |
Re: Review Request 61347: Linked `stout-tests` to `googletest`. |
Sat, 02 Sep, 20:03 |
| Joseph Wu |
Re: Review Request 61293: Removed `glog` configuration from `libprocess`. |
Sat, 02 Sep, 20:08 |
| Mesos Reviewbot |
Re: Review Request 61347: Linked `stout-tests` to `googletest`. |
Sat, 02 Sep, 20:55 |
| Joseph Wu |
Re: Review Request 61297: Linked `mesos-protobufs` to `protobuf` imported library. |
Sat, 02 Sep, 22:44 |
| Joseph Wu |
Re: Review Request 61306: Enabled building Java artifacts with CMake. |
Sat, 02 Sep, 23:09 |
| Joseph Wu |
Re: Review Request 61307: Refactored `MesosProtobuf` code. |
Sat, 02 Sep, 23:14 |
| Joseph Wu |
Re: Review Request 61311: Ported the ZooKeeper tests to CMake and Windows. |
Sun, 03 Sep, 00:13 |
| Mesos Reviewbot |
Re: Review Request 61311: Ported the ZooKeeper tests to CMake and Windows. |
Sun, 03 Sep, 00:34 |
| Joseph Wu |
Re: Review Request 61360: Cleaned up `3rdparty/CMakelists.txt`. |
Sun, 03 Sep, 00:43 |
| Joseph Wu |
Re: Review Request 61361: Replaced `MESOS_3RDPARTY_*` with `CMAKE_CURRENT_*_DIR`. |
Sun, 03 Sep, 00:58 |
| Joseph Wu |
Re: Review Request 61365: Added `get_byproducts()` function to fix Ninja generator. |
Sun, 03 Sep, 01:44 |
| Joseph Wu |
Re: Review Request 61512: Fixed up 3rdparty CMake modules. |
Sun, 03 Sep, 03:02 |
| Joseph Wu |
Re: Review Request 61514: Removed moved/deleted CMake modules from libprocess. |
Sun, 03 Sep, 03:04 |
| Joseph Wu |
Re: Review Request 61513: Removed `Mesos3rdpartyConfigure` from `MesosConfigure`. |
Sun, 03 Sep, 03:34 |
| Mesos Reviewbot |
Re: Review Request 61513: Removed `Mesos3rdpartyConfigure` from `MesosConfigure`. |
Sun, 03 Sep, 03:34 |
| Joseph Wu |
Re: Review Request 61515: Updated `CompilationConfigure.cmake` for imported libraries. |
Sun, 03 Sep, 03:37 |
| Joseph Wu |
Re: Review Request 61516: Fixed `check` and `tests` targets. |
Sun, 03 Sep, 04:54 |
| Joseph Wu |
Re: Review Request 61597: Fixed linking to `IPHlpAPI` library. |
Sun, 03 Sep, 06:20 |
| Joseph Wu |
Re: Review Request 61751: Updated Cotire.cmake module to version 1.7.10. |
Sun, 03 Sep, 06:56 |
| Joseph Wu |
Re: Review Request 61752: Audited linkage of 3rdparty dependencies. |
Sun, 03 Sep, 07:07 |
| Joseph Wu |
Re: Review Request 61753: Refactored CMake build system. |
Sun, 03 Sep, 08:00 |
| Armand Grillet |
Re: Review Request 60087: CLI: Added the ability for a plugin command to have an alias. |
Sun, 03 Sep, 08:33 |
| Armand Grillet |
Re: Review Request 61210: Renamed constants for CLI tests. |
Sun, 03 Sep, 08:34 |
| Armand Grillet |
Re: Review Request 60088: CLI: Added 'masters' key as an acceptable key in config.toml. |
Sun, 03 Sep, 08:35 |
| Armand Grillet |
Re: Review Request 61211: Added default configuration file for CLI tests. |
Sun, 03 Sep, 08:36 |
| Armand Grillet |
Re: Review Request 61212: Added CLI utility functions to check IPs and ports. |
Sun, 03 Sep, 08:37 |
| Armand Grillet |
Re: Review Request 61213: Added 'mesos task list' command to CLI. |
Sun, 03 Sep, 08:43 |
| Mesos Reviewbot |
Re: Review Request 60087: CLI: Added the ability for a plugin command to have an alias. |
Sun, 03 Sep, 10:21 |
| Joseph Wu |
Re: Review Request 61516: Fixed `check` and `tests` targets. |
Sun, 03 Sep, 12:31 |
| Mesos Reviewbot |
Re: Review Request 61210: Renamed constants for CLI tests. |
Sun, 03 Sep, 14:31 |
| Qian Zhang |
Re: Review Request 62017: Allows port mapper plugin to have optional args. |
Sun, 03 Sep, 14:35 |
| Mesos Reviewbot |
Re: Review Request 61211: Added default configuration file for CLI tests. |
Sun, 03 Sep, 17:17 |
| Qian Zhang |
Re: Review Request 60492: Added a `network/ports` isolator skeleton. |
Mon, 04 Sep, 03:47 |
| Qian Zhang |
Re: Review Request 60495: Added network ports isolator listen socket utilities. |
Mon, 04 Sep, 07:49 |
| Qian Zhang |
Re: Review Request 60495: Added network ports isolator listen socket utilities. |
Mon, 04 Sep, 09:51 |
| Mesos Reviewbot |
Re: Review Request 61213: Added 'mesos task list' command to CLI. |
Mon, 04 Sep, 10:12 |
| Benno Evers |
Re: Review Request 61495: Add documentation for possible task reasons. |
Mon, 04 Sep, 10:47 |
| Benno Evers |
Re: Review Request 61495: Add documentation for possible task reasons. |
Mon, 04 Sep, 10:47 |
| Andrei Budnik |
Re: Review Request 61798: Added SAFE_EXIT as alternative to ABORT. |
Mon, 04 Sep, 11:28 |