mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Re: Review Request 62287: Added Log::Reader::catchup() method.
Date Tue, 03 Oct 2017 23:18:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62287/
-----------------------------------------------------------

(Updated Oct. 4, 2017, 12:18 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

`recoverMissing()` function was reamed to `catchup()`.


Bugs: MESOS-7973
    https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
-------

The new method launches the 'recoverMissing' process to catch-up the
local non-leaing replica and allow safe eventually consistent reads from
it.


Diffs (updated)
-----

  include/mesos/log/log.hpp d92d7a0b982c1c4bc0fdedde19fe012a6523a224 
  src/log/log.hpp 24481aaae145301e7a8ea1c91b1c16e48ded4843 
  src/log/log.cpp dcb66f7dd5da5059925b7b731e83f7320f645030 
  src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 


Diff: https://reviews.apache.org/r/62287/diff/2/

Changes: https://reviews.apache.org/r/62287/diff/1-2/


Testing
-------

Added a test that verifies that it's possible to catch-up the lagging replica using the `Reader`
and successfully read entries that were caught-up. Ran `make check`.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message