mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Raluca Miclea <>
Subject Re: Review Request 63238: Ported and enabled Path Tests on Windows.
Date Tue, 24 Oct 2017 07:59:06 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 24, 2017, 7:59 a.m.)

Review request for mesos and Andrew Schwartzmeyer.

Bugs: MESOS-3442

Repository: mesos


I checked #ifdefs in order to decide what tests to build and run on
Window and Posix systems respectively.
For Windows tests I mainly replaced the "slash" path separator with
I extracted common assertion before the #ifdef directive.


  3rdparty/stout/tests/path_tests.cpp f8c14d5aefe0b49adb778da784143a328c96183d 


Testing (updated)

Modified Tests:
TEST(PathTest, Basename)
TEST(PathTest, Dirname)
TEST(PathTest, Extension)
TEST(PathTest, Join)


Raluca Miclea

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message