From reviews-return-66870-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Oct 10 09:55:31 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 95786102EF for ; Tue, 10 Oct 2017 09:55:31 +0000 (UTC) Received: (qmail 63800 invoked by uid 500); 10 Oct 2017 09:55:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 63771 invoked by uid 500); 10 Oct 2017 09:55:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 63737 invoked by uid 99); 10 Oct 2017 09:55:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Oct 2017 09:55:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1114E1A2F5A; Tue, 10 Oct 2017 09:30:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id pcJP3fRHtjJe; Tue, 10 Oct 2017 09:30:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B2CF35F5F7; Tue, 10 Oct 2017 09:30:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 60F1AE04F7; Tue, 10 Oct 2017 09:30:23 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E4517C402C7; Tue, 10 Oct 2017 09:30:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4738938379590786707==" MIME-Version: 1.0 Subject: Re: Review Request 60511: Added MockMetadataManager and test concurrent prune and pull. From: Mesos Reviewbot To: Jason Lai , Gilbert Song Cc: Zhitao Li , Mesos Reviewbot , mesos Date: Tue, 10 Oct 2017 09:30:21 -0000 Message-ID: <20171010093021.33205.46389@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/60511/ X-Sender: Mesos Reviewbot References: <20171009232109.34460.5882@reviews-vm2.apache.org> In-Reply-To: <20171009232109.34460.5882@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============4738938379590786707== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60511/#review187511 ----------------------------------------------------------- Patch looks great! Reviews applied: [55334, 55335, 59687, 56721, 56722, 60471, 62853, 60511] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 9, 2017, 11:21 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60511/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2017, 11:21 p.m.) > > > Review request for mesos, Gilbert Song and Jason Lai. > > > Bugs: MESOS-4945 > https://issues.apache.org/jira/browse/MESOS-4945 > > > Repository: mesos > > > Description > ------- > > Added MockMetadataManager and test concurrent prune and pull. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 954da1681778878c8aff6150002e52ecb648d1bb > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp d86afd2a6ff0bf87e624db1c99255c85068bf6ab > src/slave/containerizer/mesos/provisioner/docker/store.hpp 1cf68665d33bd40a7605d26c96fb7b618407fdd0 > src/slave/containerizer/mesos/provisioner/docker/store.cpp f357710cb19aec3654b0604f7909d068eaf20095 > src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4 > > > Diff: https://reviews.apache.org/r/60511/diff/6/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > > --===============4738938379590786707==--