mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 63499: Fixed the unit test that broke Windows build.
Date Thu, 02 Nov 2017 17:57:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189939
-----------------------------------------------------------




src/tests/default_executor_tests.cpp
Lines 1413-1414 (patched)
<https://reviews.apache.org/r/63499/#comment267185>

    Re: Alex's comment above:
    
    > MESOS-6698 is resolved. We probably should reopen it or file a new ticket and update
the comment. Or maybe make kill helpers work on windows ; )?
    
    I second this; this comment is inaccurate as (a) hausdorff no longer works on Mesos, and
(b) the mentioned issue is closed. We need at minimum a new issue for enabling kill policy
helperps on Windows. You can put the TODO and issue assignee as me.


- Andrew Schwartzmeyer


On Nov. 2, 2017, 1:27 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 1:27 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> -------
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message