mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.
Date Thu, 02 Nov 2017 19:52:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63353/
-----------------------------------------------------------

(Updated Nov. 2, 2017, 12:52 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.


Changes
-------

We found out that there's actually no need to clear executor IDs at any point.


Bugs: MESOS-8135
    https://issues.apache.org/jira/browse/MESOS-8135


Repository: mesos


Description
-------

Previously the agent would sometimes clear the executor ID of
non-command executors before sending the `ReregisterSlaveMessage`
message.


Diffs (updated)
-----

  src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 


Diff: https://reviews.apache.org/r/63353/diff/3/

Changes: https://reviews.apache.org/r/63353/diff/2-3/


Testing
-------

Verified that the new test fails on GNU/Linux without the rest of the patch, but passes with
it.


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message