mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 63474: Added a regression test for MESOS-8135.
Date Thu, 02 Nov 2017 22:13:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63474/#review189975
-----------------------------------------------------------


Fix it, then Ship it!




Would be great to have some better testing abstractions to clean up this test!


src/tests/master_slave_reconciliation_tests.cpp
Lines 718-720 (patched)
<https://reviews.apache.org/r/63474/#comment267217>

    Let's maybe adjust this to reflect that we're testing the API as well?



src/tests/master_slave_reconciliation_tests.cpp
Lines 852-854 (patched)
<https://reviews.apache.org/r/63474/#comment267221>

    In general, I think wrapping for less jaggedness is more readable:
    
    ```
          EXPECT_FALSE(task.has_executor_id())
            << "The command executor ID is present, but it"
            << " shouldn't be sent to the master";
    ```



src/tests/master_slave_reconciliation_tests.cpp
Lines 898 (patched)
<https://reviews.apache.org/r/63474/#comment267222>

    default



src/tests/master_slave_reconciliation_tests.cpp
Lines 899-901 (patched)
<https://reviews.apache.org/r/63474/#comment267224>

    The following looks a little more readable?
    
    ```
    EXPECT_EQ(defaultExecutorInfo.executor_id().value(),
              defaultExecutorTaskExecutorId);
    ```


- Benjamin Mahler


On Nov. 2, 2017, 7:51 p.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63474/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 7:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Vinod Kone.
> 
> 
> Bugs: MESOS-8135
>     https://issues.apache.org/jira/browse/MESOS-8135
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a regression test for MESOS-8135.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp d5eb7ba68c5308338236879e7cb1e970a01e48e6

> 
> 
> Diff: https://reviews.apache.org/r/63474/diff/2/
> 
> 
> Testing
> -------
> 
> Test passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message