mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 63499: Fixed the unit test that broke Windows build.
Date Thu, 02 Nov 2017 23:51:59 GMT


> On Nov. 3, 2017, 1:57 a.m., Andrew Schwartzmeyer wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1413-1414 (patched)
> > <https://reviews.apache.org/r/63499/diff/1/?file=1878739#file1878739line1413>
> >
> >     Re: Alex's comment above:
> >     
> >     > MESOS-6698 is resolved. We probably should reopen it or file a new ticket
and update the comment. Or maybe make kill helpers work on windows ; )?
> >     
> >     I second this; this comment is inaccurate as (a) hausdorff no longer works on
Mesos, and (b) the mentioned issue is closed. We need at minimum a new issue for enabling
kill policy helperps on Windows. You can put the TODO and issue assignee as me.

Agree, I have created a [new ticket](https://issues.apache.org/jira/browse/MESOS-8168) for
it, and also updated this comment and also the comment in command_executor_tests.cpp.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63499/#review189939
-----------------------------------------------------------


On Nov. 2, 2017, 4:27 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63499/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 4:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the unit test that broke Windows build.
> 
> 
> Diffs
> -----
> 
>   src/tests/default_executor_tests.cpp 21950f57e9eae741ac219d930fe9c4fc94d4f47f 
> 
> 
> Diff: https://reviews.apache.org/r/63499/diff/1/
> 
> 
> Testing
> -------
> 
> No need to run test since this patch is only for disable a test on Windows.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message