mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Review Request 63577: Fixed a task status update race in default executor tests.
Date Mon, 06 Nov 2017 13:31:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63577/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Gaston Kleiman.


Repository: mesos


Description
-------

Previously in the test `DefaultExecutorTest.KillMultipleTasks` and
`DefaultExecutorTest.KillTaskGroupOnTaskFailure`, when launching a
task group which has multiple tasks, we expected the scheduler will
receive all the TASK_STARTING status updates before receiving any
TASK_RUNNING status updates. However this is not guaranteed, e.g.,
it is possible for the scheduler to receive TASK_RUNNING for the
first task before receiving TASK_STARTING for the second task.

So in this patch, we used `Sequence` to guarantee the order of
TASK_STARTING and TASK_RUNNING for each task but do not care about
the order between tasks.

The following 3 tests have their own solutions to handle this issue,
in this patch, I updated them to use the above solution.
  `DefaultExecutorTest.KillTask`
  `DefaultExecutorTest.CommitSuicideOnKillTask`
  `DefaultExecutorTest.ROOT_ContainerStatusForTask`


Diffs
-----

  src/tests/default_executor_tests.cpp 65113985acc0a8fac00374b074ef568aaa22c7ac 
  src/tests/mesos.hpp e25defeb55608136e77363aa48cf820092a13a59 


Diff: https://reviews.apache.org/r/63577/diff/1/


Testing
-------

This patch touched 5 tests:
1. KillTask
2. KillMultipleTasks
3. KillTaskGroupOnTaskFailure
4. CommitSuicideOnKillTask
5. ROOT_ContainerStatusForTask

I ran each of them repeatedly (20 times), and all of them succeeded.


Thanks,

Qian Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message