mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 63581: Created virtual environment for linters in /support.
Date Mon, 06 Nov 2017 15:11:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63581/#review190161
-----------------------------------------------------------




support/build-virtualenv
Lines 55 (patched)
<https://reviews.apache.org/r/63581/#comment267420>

    Should be for linters, not Web UI



support/build-virtualenv
Lines 63-66 (patched)
<https://reviews.apache.org/r/63581/#comment267423>

    Is this necessary in here? I think this was for the CLI only (and I assume you copied
this from in there an modified it slightly).



support/mesos-style.py
Lines 365 (patched)
<https://reviews.apache.org/r/63581/#comment267429>

    We don't need this. We have already checked this above.



support/mesos-style.py
Lines 371 (patched)
<https://reviews.apache.org/r/63581/#comment267427>

    Also need to trigger this if `build-virtualenv` changes.



support/mesos-style.py
Lines 372-375 (patched)
<https://reviews.apache.org/r/63581/#comment267428>

    I don't think this is necessary. I know I added it here myself, but I don't remember why
anymore and it doesn't seem necessary.


- Kevin Klues


On Nov. 6, 2017, 2:52 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63581/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change affects the Python linter but not the C++ linter as we
> use a customized version of cpplint that we cannot get using pip.
> 
> 
> Diffs
> -----
> 
>   src/python/pylint.config  
>   support/build-virtualenv PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
>   support/pip-requirements.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63581/diff/1/
> 
> 
> Testing
> -------
> 
> Used the linters after applying this patch.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message