mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63485: Added initial code for offer operation status update in master.
Date Mon, 06 Nov 2017 15:29:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63485/#review190162
-----------------------------------------------------------




src/master/master.cpp
Lines 5161-5162 (original), 5164-5165 (patched)
<https://reviews.apache.org/r/63485/#comment267432>

    I am not sure why we went from a managed ptr to a raw pointer here and below. It e.g.,
seems we now leak `offerOperation`s (this patch just adds `new`, but no matching `delete`).
    
    Could we just keep using `Owned<OfferOperation>` here?



src/master/master.cpp
Line 5201 (original), 5207 (patched)
<https://reviews.apache.org/r/63485/#comment267433>

    This also seems to be leaked now.



src/master/master.cpp
Lines 5241-5242 (original), 5250-5251 (patched)
<https://reviews.apache.org/r/63485/#comment267434>

    Also leaked.



src/master/master.cpp
Lines 7257 (patched)
<https://reviews.apache.org/r/63485/#comment267437>

    I feel it might make more sense to log the ID of the agent injecting faulty operation
IDs than the framework which triggered the operation.


- Benjamin Bannier


On Nov. 2, 2017, 12:18 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63485/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 12:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann,
and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial code for offer operation status update in master.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 
>   src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 
> 
> 
> Diff: https://reviews.apache.org/r/63485/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message