mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 62734: Added Markdown, bug, and reviewers support to `post-reviews.py`.
Date Mon, 06 Nov 2017 18:07:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62734/
-----------------------------------------------------------

(Updated Nov. 6, 2017, 10:07 a.m.)


Review request for mesos, Joseph Wu, Michael Park, and Till Toenshoff.


Changes
-------

Fixed boolean bug.


Repository: mesos


Description (updated)
-------

These options are appropriately forwarded to `rbt`.

We enable Markdown parsing by default, with `--no-markdown` to disable
it; this is safe as most commit formatting is intended to be Markdown,
and unformatted text is valid markdown. This prevents `rbt` from
escaping e.g. ticks used in commit messages that are then manually
removed from reviews on Review Board.

The `--bugs-closed` flag lets users attach a bug automatically to every
review in the chain they're posting. Similarly `--target-people` will
attach the specified reviewers to every review. This reduces the amount
of work it takes to prepare chains of reviews.

We added help to the argument parser of the script, mostly stolen from
the descriptions in `rbt post --help`.


Diffs (updated)
-----

  support/post-reviews.py c9378719f5ab38052bd87fab73ab9b5bd37e0154 


Diff: https://reviews.apache.org/r/62734/diff/3/

Changes: https://reviews.apache.org/r/62734/diff/2-3/


Testing
-------

Used it to post this patch.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message