mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.
Date Mon, 06 Nov 2017 21:50:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55335/#review190225
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1091-1092 (original), 1096-1105 (patched)
<https://reviews.apache.org/r/55335/#comment267524>

    do you miss these?



src/tests/containerizer/mesos_containerizer_tests.cpp
Lines 1180-1186 (patched)
<https://reviews.apache.org/r/55335/#comment267525>

    ditto.


- Gilbert Song


On Oct. 27, 2017, 11:01 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55335/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 11:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.
> 
> 
> Bugs: MESOS-6894
>     https://issues.apache.org/jira/browse/MESOS-6894
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests were using a `TaskInfo` field which is missing required
> protobuf fields. After the previous patch begins to checkpoint
> `ContainerConfig`, the incomplete `TaskInfo` cannot be checkpointed,
> thus caused these tests to fail.
> 
> This patch backfills these fields to make these tests pass.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp e61a85df6ec5308ccd2832e66df803b0ad7b53ee

> 
> 
> Diff: https://reviews.apache.org/r/55335/diff/7/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="MesosContainerizer*" make check
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message