mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63491: Added resource version to resource provider UpdateTotalResources call.
Date Mon, 06 Nov 2017 22:12:17 GMT


> On Nov. 6, 2017, 10:51 p.m., Greg Mann wrote:
> > src/resource_provider/manager.cpp
> > Lines 368-371 (patched)
> > <https://reviews.apache.org/r/63491/diff/2/?file=1881894#file1881894line368>
> >
> >     I found a couple other spots where we indent four spaces in this situation,
perhaps we should do the same here? I don't think our style guide explicitly mentions indentation
of initialization lists, but the Google style guide does say:
> >     
> >     "Format a braced initializer list exactly like you would format a function call
in its place."

Yeah, this makes sense to me. This is an aggregate initialization and the Google style guide
suggests just what you wrote above. Strangly enough our `clang-format` indents this correctly
when written as a function call with `()`, but gave above format for `{}`.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63491/#review190189
-----------------------------------------------------------


On Nov. 6, 2017, 11:12 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63491/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2017, 11:12 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch surfaces this information to resource provider manager
> users like the agent. In a later patch we will modify the agent to
> forward this information to the master.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e 
>   src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 
>   src/tests/slave_tests.cpp 9c2db7adf45af4209ecc475d938ce4b77c5a3ab4 
> 
> 
> Diff: https://reviews.apache.org/r/63491/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message