mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 63495: Added comparison operators for 'ResourceVerionUUID'.
Date Mon, 06 Nov 2017 22:51:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63495/#review190239
-----------------------------------------------------------


Fix it, then Ship it!





src/messages/messages.cpp
Lines 42-46 (patched)
<https://reviews.apache.org/r/63495/#comment267540>

    You could simply do
    ```
    return left.uuid() == right.uuid();
    ```
    but not a big deal; feel free to drop this issue if you desire.


- Greg Mann


On Nov. 2, 2017, 1:57 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63495/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2017, 1:57 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added comparison operators for 'ResourceVerionUUID'.
> 
> 
> Diffs
> -----
> 
>   src/messages/messages.hpp 59e670532c8eb1ab1ec6cb063ace03481cd6a33d 
>   src/messages/messages.cpp 7f1da63ae67b3918851c2c1dd225bfd2d0044387 
> 
> 
> Diff: https://reviews.apache.org/r/63495/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message