mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 63492: Synchronized agent clock with master via 'UpdateSlaveMessage'.
Date Tue, 07 Nov 2017 12:25:57 GMT


> On Nov. 6, 2017, 11:35 p.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 6946 (patched)
> > <https://reviews.apache.org/r/63492/diff/4/?file=1881898#file1881898line6946>
> >
> >     Hmm this should be `UUID::fromBytes`, right?

Good catch, thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63492/#review190232
-----------------------------------------------------------


On Nov. 7, 2017, 1:25 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63492/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 1:25 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit introduces agent clocks to the master and agents. Agents
> are responsible for maintaining their clock. The clocks are
> synchronized with the master via 'UpdateSlaveMessage'.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp afcc2e46882e4c610e9047ab3db7b6f100d47e17 
>   src/master/master.cpp 49bc50ead75adba82a7d8de23a87b06ccd269c48 
>   src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
>   src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a 
> 
> 
> Diff: https://reviews.apache.org/r/63492/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`, additional testing as part of https://reviews.apache.org/r/63496/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message