mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63519: Allowed toggling of agent capabilities via command line flags.
Date Tue, 07 Nov 2017 22:23:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63519/#review190375
-----------------------------------------------------------




docs/configuration/agent.md
Lines 101-103 (patched)
<https://reviews.apache.org/r/63519/#comment267707>

    Please update these.



src/slave/flags.cpp
Lines 653-655 (patched)
<https://reviews.apache.org/r/63519/#comment267708>

    Ditto.


- Jie Yu


On Nov. 7, 2017, 10 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63519/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2017, 10 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces a new agent command line flags
> '--agent_features' which can be used to whitelist capabilities to
> enable. This flag is intended to enable introducing feature flags in
> the future so experimental features can be added while still reducing
> the risk of breaking existing functionality. Currently only the
> 'RESOURCE_PROVIDER' capability can be toggled.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 116e7c6b10d6eafdf6a163c821d2204db29f6d4c 
>   src/slave/flags.hpp d02edbfd68266c9f2d5c78fdbd5c2ba5f497adba 
>   src/slave/flags.cpp 63aaac218fdc067742d39f1fc8497723784d9595 
>   src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 
>   src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 
> 
> 
> Diff: https://reviews.apache.org/r/63519/diff/6/
> 
> 
> Testing
> -------
> 
> `make check`, tested as part of https://reviews.apache.org/r/63496/
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message