mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 64226: Added a `ns::supported` convenience API.
Date Fri, 01 Dec 2017 23:46:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64226/
-----------------------------------------------------------

(Updated Dec. 1, 2017, 11:46 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Address review feedback.


Bugs: MESOS-8284
    https://issues.apache.org/jira/browse/MESOS-8284


Repository: mesos


Description (updated)
-------

Added a `ns::supported` convenience API which directly expresses the
intent to probe whether a specific Linux namespace is supported on
the running kernel and takes care of kernel versioning special cases.

This API subsumes the previous usages of `ns::namespaces`, so that API
is now used only retained as an internal helper.


Diffs (updated)
-----

  src/linux/ns.hpp e24d79a41eefcade343b2825b5a758d7d30a5f91 
  src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139 
  src/slave/containerizer/mesos/isolators/namespaces/ipc.cpp 2d89d598d24e3bcf01d652ce3f586c9e3ccfc20b

  src/slave/containerizer/mesos/isolators/namespaces/pid.cpp 4f8253b58018581e022eb1832b9b07703cbd318d

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp d60052e9e1ccdfaaac6c0db6acfdae325cea6a9e

  src/tests/containerizer/ns_tests.cpp 61adf8525b1df1a70d7fd9c747d2106630a7627d 
  src/tests/containerizer/setns_test_helper.cpp 045caf684baf6e724fa5f99b6cc3feeb87817ba3 


Diff: https://reviews.apache.org/r/64226/diff/3/

Changes: https://reviews.apache.org/r/64226/diff/2-3/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message