mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 64232: Add a temporary filter for overlay backend related tests.
Date Sat, 02 Dec 2017 02:01:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64232/#review192613
-----------------------------------------------------------


Fix it, then Ship it!




LGTM!


src/tests/environment.cpp
Lines 555-622 (patched)
<https://reviews.apache.org/r/64232/#comment270870>

    ditto. please move the code above alphabetically.



src/tests/environment.cpp
Lines 558 (patched)
<https://reviews.apache.org/r/64232/#comment270866>

    add:
    
    It is due to .... Please see MESOS-xxxx for details.



src/tests/environment.cpp
Lines 561 (patched)
<https://reviews.apache.org/r/64232/#comment270865>

    s/root directory/root directory of the agent's work dir/g



src/tests/environment.cpp
Lines 581 (patched)
<https://reviews.apache.org/r/64232/#comment270868>

    Remember to add a period for your comments at the end.
    
    ```
    // Clean up the temporary directory that is used for d_type detection.
    ```



src/tests/environment.cpp
Lines 600-601 (patched)
<https://reviews.apache.org/r/64232/#comment270867>

    add to TODO: Avoid hard coding a specific directory for filtering. This is a temporary
solution.



src/tests/environment.cpp
Lines 601 (patched)
<https://reviews.apache.org/r/64232/#comment270864>

    instead of hard coding it. could we use `os::temp()`?



src/tests/environment.cpp
Lines 775 (patched)
<https://reviews.apache.org/r/64232/#comment270869>

    I am assuming the filters are sorted alphabetically. Could you adjust it?


- Gilbert Song


On Dec. 1, 2017, 1:01 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64232/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2017, 1:01 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a temporary filter to disable tests that use
> overlay as backend on filesystems where `d_type` support is
> missing. In particular, many XFS nodes are known to have this
> issue.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef

>   src/tests/environment.cpp 607ac6cf903c71bdf8e2f4e08581ef2a352db7cd 
> 
> 
> Diff: https://reviews.apache.org/r/64232/diff/2/
> 
> 
> Testing
> -------
> 
> Checked affected tests.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message