mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 64271: Added an unit test for docker image auto gc.
Date Sat, 02 Dec 2017 09:27:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64271/#review192625
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/provisioner_docker_tests.cpp
Lines 463 (patched)
<https://reviews.apache.org/r/64271/#comment270888>

    Please add a comment to describe the purpose of this test.



src/tests/containerizer/provisioner_docker_tests.cpp
Lines 561 (patched)
<https://reviews.apache.org/r/64271/#comment270889>

    Why calling `paths::listLayer()` again here? Can we directly check `layers` returned from
the above `while` loop?


- Qian Zhang


On Dec. 2, 2017, 9:10 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64271/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2017, 9:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Qian Zhang, Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-8294
>     https://issues.apache.org/jira/browse/MESOS-8294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added an unit test for docker image auto gc.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 832c81fe88d753b0f00dfab870d7725cf556fcef

> 
> 
> Diff: https://reviews.apache.org/r/64271/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message