mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 63914: Changed agent reregistration to work with message directly.
Date Mon, 04 Dec 2017 17:57:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63914/#review192721
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Line 6433 (original), 6394 (patched)
<https://reviews.apache.org/r/63914/#comment270977>

    I think these `message` to `message_` changes should either take the type of the mesage
(e.g., `shutdown`), or simply a `s/message/outgoing/`. Having unrelated `message` and `message_`
in the same scope will likely cause confusion.



src/master/master.cpp
Line 6823 (original), 6779 (patched)
<https://reviews.apache.org/r/63914/#comment270974>

    I think the intention is that we move this, right? I think the `Slave` ctor was updated
on the next patch to take `vector`, rather than `vector&&`. Maybe we should make it
`vector&&` such that we don't run into this?
    
    Same with `agentCapabilities` and other related data


- Michael Park


On Nov. 21, 2017, 9:53 a.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63914/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2017, 9:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
>     https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `reregisterSlave` now accepts `ReregisterSlaveMessage&&`, which opts-out
> of using protobuf arena, and allows passing message through dispatch
> chain without making any copies.
> Conversion of repeated message fields to `std::vector`s is performed
> only when needed.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 0f8a2ac72c3484f911853c2994fc71a488d66d96 
>   src/master/master.cpp fadc78b2ca5d46b8cc12a794b428753aa79ac095 
>   src/master/validation.hpp ac54062ea09f97ad96bd17deb106ea89a57f394a 
>   src/master/validation.cpp 8b5848bfd8c069f34a92a9a68597955c6e0c2ee2 
>   src/tests/master_validation_tests.cpp 0e1c8b490ebe10bc50b8b6b530fa85128b967584 
> 
> 
> Diff: https://reviews.apache.org/r/63914/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message